button.js ➔ ... ➔ - Code Metrics - Inspection of "[TASK] Move layer genertation to layer" - ffrgb/meshviewer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#128)

by Xaver

created 2017-04-26 21:53 UTC

button.js ➔ ... ➔ B

↳ Parent: button.js ➔ define

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
c	1
b	0
f	0
nc	1
dl	0
loc	88
rs	8.6012
nop	4

How to fix Long Method

define(['map/clientlayer', 'map/labellayer', 'leaflet', 'moment', 'map/locationmarker'],
  function (ClientLayer, LabelLayer, L, moment, LocationMarker) {
    'use strict';
    var self = {};

    var ButtonBase = L.Control.extend({
      options: {
        position: 'bottomright'
      },

      active: false,
      button: undefined,

      initialize: function (f, o) {
        L.Util.setOptions(this, o);
        this.f = f;
      },

      update: function () {
        this.button.classList.toggle('active', this.active);
      },

      set: function (v) {
        this.active = v;
        this.update();
      }
    });

    var LocateButton = ButtonBase.extend({
      onAdd: function () {
        var button = L.DomUtil.create('button', 'ion-locate shadow');
        button.setAttribute('data-tooltip', _.t('button.tracking'));
        L.DomEvent.disableClickPropagation(button);
        L.DomEvent.addListener(button, 'click', this.onClick, this);

        this.button = button;

        return button;
      },

      onClick: function () {
        this.f(!this.active);
      }
    });

    var CoordsPickerButton = ButtonBase.extend({
      onAdd: function () {
        var button = L.DomUtil.create('button', 'ion-pin shadow');
        button.setAttribute('data-tooltip', _.t('button.location'));

        // Click propagation isn't disabled as this causes problems with the
        // location picking mode; instead propagation is stopped in onClick().
        L.DomEvent.addListener(button, 'click', this.onClick, this);

        this.button = button;

        return button;
      },

      onClick: function (e) {
        L.DomEvent.stopPropagation(e);
        this.f(!this.active);
      }
    });

    return function (config, map, router, buttons) {
      var userLocation;

      var locateUserButton = new LocateButton(function (d) {
        if (d) {
          enableTracking();
        } else {
          self.disableTracking();
        }
      });

      var mybuttons = [];

      function addButton(button) {
        var el = button.onAdd();
        mybuttons.push(el);
        buttons.appendChild(el);
      }

      self.clearButtons = function clearButtons() {
        mybuttons.forEach(function (d) {
          buttons.removeChild(d);
        });
      };

      var showCoordsPickerButton = new CoordsPickerButton(function (d) {
        if (d) {
          enableCoords();
        } else {
          disableCoords();
        }
      });

      function enableTracking() {
        map.locate({
          watch: true,
          enableHighAccuracy: true,
          setView: true
        });
        locateUserButton.set(true);
      }

      self.disableTracking = function disableTracking() {
        map.stopLocate();
        self.locationError();
        locateUserButton.set(false);
      };

      function enableCoords() {
        map.getContainer().classList.add('pick-coordinates');
        map.on('click', showCoordinates);
        showCoordsPickerButton.set(true);
      }

      function disableCoords() {
        map.getContainer().classList.remove('pick-coordinates');
        map.off('click', showCoordinates);
        showCoordsPickerButton.set(false);
      }

      function showCoordinates(e) {
        router.fullUrl({ zoom: map.getZoom(), lat: e.latlng.lat, lng: e.latlng.lng });
        disableCoords();
      }

      self.locationFound = function locationFound(e) {
        if (!userLocation) {
          userLocation = new LocationMarker(e.latlng).addTo(map);
        }

        userLocation.setLatLng(e.latlng);
        userLocation.setAccuracy(e.accuracy);
      };

      self.locationError = function locationError() {
        if (userLocation) {
          map.removeLayer(userLocation);
          userLocation = null;
        }
      };

      self.init = function init() {
        addButton(locateUserButton);
        addButton(showCoordsPickerButton);
      };

      return self;
    };
  });


1			define(['map/clientlayer', 'map/labellayer', 'leaflet', 'moment', 'map/locationmarker'],
2			function (ClientLayer, LabelLayer, L, moment, LocationMarker) {
3			'use strict';
4			var self = {};
5
6			var ButtonBase = L.Control.extend({
7			options: {
8			position: 'bottomright'
9			},
10
11			active: false,
12			button: undefined,
13
14			initialize: function (f, o) {
15			L.Util.setOptions(this, o);
16			this.f = f;
17			},
18
19			update: function () {
20			this.button.classList.toggle('active', this.active);
21			},
22
23			set: function (v) {
24			this.active = v;
25			this.update();
26			}
27			});
28
29			var LocateButton = ButtonBase.extend({
30			onAdd: function () {
31			var button = L.DomUtil.create('button', 'ion-locate shadow');
32			button.setAttribute('data-tooltip', _.t('button.tracking'));
33			L.DomEvent.disableClickPropagation(button);
34			L.DomEvent.addListener(button, 'click', this.onClick, this);
35
36			this.button = button;
37
38			return button;
39			},
40
41			onClick: function () {
42			this.f(!this.active);
43			}
44			});
45
46			var CoordsPickerButton = ButtonBase.extend({
47			onAdd: function () {
48			var button = L.DomUtil.create('button', 'ion-pin shadow');
49			button.setAttribute('data-tooltip', _.t('button.location'));
50
51			// Click propagation isn't disabled as this causes problems with the
52			// location picking mode; instead propagation is stopped in onClick().
53			L.DomEvent.addListener(button, 'click', this.onClick, this);
54
55			this.button = button;
56
57			return button;
58			},
59
60			onClick: function (e) {
61			L.DomEvent.stopPropagation(e);
62			this.f(!this.active);
63			}
64			});
65
66			return function (config, map, router, buttons) {
67			var userLocation;
68
69			var locateUserButton = new LocateButton(function (d) {
70			if (d) {
71			enableTracking();
72			} else {
73			self.disableTracking();
74			}
75			});
76
77			var mybuttons = [];
78
79			function addButton(button) {
80			var el = button.onAdd();
81			mybuttons.push(el);
82			buttons.appendChild(el);
83			}
84
85			self.clearButtons = function clearButtons() {
86			mybuttons.forEach(function (d) {
87			buttons.removeChild(d);
88			});
89			};
90
91			var showCoordsPickerButton = new CoordsPickerButton(function (d) {
92			if (d) {
93			enableCoords();
94			} else {
95			disableCoords();
96			}
97			});
98
99			function enableTracking() {
100			map.locate({
101			watch: true,
102			enableHighAccuracy: true,
103			setView: true
104			});
105			locateUserButton.set(true);
106			}
107
108			self.disableTracking = function disableTracking() {
109			map.stopLocate();
110			self.locationError();
111			locateUserButton.set(false);
112			};
113
114			function enableCoords() {
115			map.getContainer().classList.add('pick-coordinates');
116			map.on('click', showCoordinates);
117			showCoordsPickerButton.set(true);
118			}
119
120			function disableCoords() {
121			map.getContainer().classList.remove('pick-coordinates');
122			map.off('click', showCoordinates);
123			showCoordsPickerButton.set(false);
124			}
125
126			function showCoordinates(e) {
127			router.fullUrl({ zoom: map.getZoom(), lat: e.latlng.lat, lng: e.latlng.lng });
128			disableCoords();
129			}
130
131			self.locationFound = function locationFound(e) {
132			if (!userLocation) {
133			userLocation = new LocationMarker(e.latlng).addTo(map);
134			}
135
136			userLocation.setLatLng(e.latlng);
137			userLocation.setAccuracy(e.accuracy);
138			};
139
140			self.locationError = function locationError() {
141			if (userLocation) {
142			map.removeLayer(userLocation);
143			userLocation = null;
144			}
145			};
146
147			self.init = function init() {
148			addButton(locateUserButton);
149			addButton(showCoordsPickerButton);
150			};
151
152			return self;
153			};
154			});
155

ffrgb / meshviewer

Pull Request — develop (#128)

button.js ➔ ... ➔ B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like